Skip to content

tools: unify make-v8.sh for ppc64le and s390x

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/testv8 into master

Refactor tools/make-v8.sh to minimise differences between the ppc64le and s390x paths to allow us to enable ccache on the ppc64le machines in the CI.

This needs to land in all supported release lines tested on before we can reenable ccache on the centos7-ppcle machines (i.e. reland https://github.com/nodejs/build/pull/1927 which was backed out because the divergent ppc64le and s390x paths through this script broke node-test-commit-v8-linux (https://github.com/nodejs/build/issues/1940)).

Refs: https://github.com/nodejs/build/pull/1927 Refs: https://github.com/nodejs/build/issues/1940

cc @nodejs/platform-ppc @nodejs/platform-s390

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports