Skip to content

12.x reverts

Rodrigo Muino Tomonari requested to merge github/fork/MylesBorins/12.x-reverts into v12.x-staging

This includes are revert of https://github.com/nodejs/node/pull/31063 and https://github.com/nodejs/node/commit/65e5a8a90cd85fc4d9036bc4b54e0905edd8b51a as both seemed to have caused regression in v12.16.0

https://github.com/nodejs/node/issues/31752 https://github.com/nodejs/node/issues/31249#issuecomment-585636203

I believe that https://github.com/nodejs/node/commit/65e5a8a90cd85fc4d9036bc4b54e0905edd8b51a should be able to land with a fix in the next 12.x release. As This includes are revert of https://github.com/nodejs/node/pull/31063 is SemverMinor it would have to wait until April to get out in the next release.

As such I wanted to open this PR to get consensus on landing the reverts before doing so.

Merge request reports