Skip to content

fs: fix WriteStream autoClose order

Rodrigo Muino Tomonari requested to merge github/fork/nxtedition/fs-autoclose-order into master

WriteStream autoClose was implemented by manually calling .destroy() instead of using autoDestroy and callback. This caused some invariants related to order of events to be broken.

Fixes: https://github.com/nodejs/node/issues/31776

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports