Skip to content

http: align with stream.Writable

Rodrigo Muino Tomonari requested to merge github/fork/nxtedition/http-writable into master

This PR works towards consolidating the behavior of http.OutgoingMessage, which is considered "streamlike", with stream.Writable.

This does cause some breaking changes that need to be considered.

Some of the breaking changes:

  • write() return false on write after end.
  • More error types in write().
  • Don't throw errors. Instead invoke callback and emit error.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports