Skip to content

src: move BaseObject subclass dtors/ctors out of node_crypto.h

Rodrigo Muino Tomonari requested to merge github/fork/jasnell/move_baseobj_ctors into master

Originally landed in the QUIC repo. Separated from from the QUIC PR. There is nothing QUIC specific in this change.

Move constructor and destructors for subclasses of BaseObject from node_crypto.h to node_crypto.cc. This removes the need to include base_object-inl.h when using node_crypto.h in some cases.

Original review metadata:

  PR-URL: https://github.com/nodejs/quic/pull/220
  Reviewed-By: Anna Henningsen <anna@addaleax.net>
  Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports