build: add asan check in Github action (!31902) · Merge requests · Rodrigo Test / Test Group-nodejs / node · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Rodrigo Muino Tomonari requested to merge github/fork/gengjiawen/ci/asan into master Feb 21, 2020

This related to https://github.com/nodejs/node/issues/30257

This currently only runs on linux only. Acutally windows has made some progress on this too, see https://devblogs.microsoft.com/cppblog/addresssanitizer-asan-for-windows-with-msvc/, but it require cmake as build toolchain IIUC. Also current code asan checks broken on macOS, so I didn't add them.

currrent Docker Image source: https://github.com/gengjiawen/node-build/blob/master/Dockerfile.

todo

fix current asan issue
move node docker to official repo, need to setup a new repo.
skip some failed test due to asan flag
should check gcc and clang both, they have difference https://github.com/google/sanitizers/wiki/AddressSanitizerClangVsGCC-(6.0-vs-8.1)

Hopefully we can remove continue-on-error in the future.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines