Skip to content

http,stream: make virtual methods throw an error

Rodrigo Muino Tomonari requested to merge github/fork/lpinca/throw/err-method-not-implemented into master

Make virtual methods throw an ERR_METHOD_NOT_IMPLEMENTED error instead of emitting it.

The error is not recoverable and the only way to handle it is to override the method.

Refs: https://github.com/nodejs/node/pull/31818#pullrequestreview-359403469

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports