Skip to content

buffer: FreeCallback should be tied to ArrayBuffer

Rodrigo Muino Tomonari requested to merge github/fork/indutny/fix/buffer-wrong-free-callback-handle into master

FreeCallback should be invoked on the storage disposal (ArrayBuffer), not when the view (Uint8Array or Buffer) is disposed. This causes bug and crashes in addons which create buffers and store only slices of them.

cc @trevnorris @bnoordhuis @nodejs/collaborators

Merge request reports