Skip to content

src: add node_crypto_common and refactor

Rodrigo Muino Tomonari requested to merge github/fork/jasnell/crypto-common-refactor into master

Two things in one on this commit:

(a) For the QUIC implementation, we need to separate out various bits from node_crypto.cc to allow them to be reused. That's where this commit starts.

(b) Quite a bit of the node_crypto.cc code was just messy in terms of it's organization and lack of error handling and use of Local vs. MaybeLocal. This cleans that up a bit and hopefully makes certain parts a bit more manageable also.

There is nothing QUIC specific in this PR but there are pieces in here that are only used by the QUIC implementation currently. I am separating things out to make them easier to review in smaller chunks.

This PR does include a number of changes that are not yet in the QUIC version as I decided once I started separating it out to do some additional cleanup while I was in there.

These should all be internal changes with no changes to public API at all.

Signed-off-by: James M Snell jasnell@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports