deps: update V8 to 8.1
Chrome release date: Mar 17th, 2020.
There's one outstanding issue on 8.0 (nodejs/node-v8#120), but it might not be worth blocking the upgrade because of that (we're unlikely to see that issue outside very specific, synthetic test cases).
Depends on:
-
https://github.com/nodejs/node/pull/32113 -
https://github.com/nodejs/node/pull/32114 -
https://github.com/nodejs/node/pull/32133 -
https://github.com/nodejs/node/pull/32140 -
https://github.com/nodejs/node/pull/32234 -
https://github.com/nodejs/node/pull/32239
Current failing tests and builds:
-
sequential/test-inspector-break-when-eval
is flaky (likely the same as nodejs/node-v8#120)- Child process is crashing with SIGSEGV, so it's likely the same issue.
-
Removed MemoryMeasurement::Request::= being called (only Windows is complaining) -
ASAN build is broken on CI (skip failures https://github.com/nodejs/node/pull/32116#issuecomment-597403627)
Flaky tests (possibly introduced here):
-
sequential/test-inspector-break-when-eval
also giving an assertion error sometimes- Subprocess failed on timers.js
-
sequential/test-heap-prof
timeout -
parallel/test-repl-history-navigation
-
parallel/test-memory-usage
- being tracked on https://github.com/nodejs/node-v8/issues/144
- Fixed with https://github.com/nodejs/node/pull/32239
-
sequential/test-cpu-prof-drained
might be flakyThe assert failed because an error was thrown in the subprocess, causing the wrong stack to be sampledThe subprocess failed while trying to loadfibonacci.js
, apparently on assertSize- Looking at the stack again, there's no guarantee an error was thrown, just that the stack was captured by the inspector while opening a file (likely
fibonacci.js
)
-
corrupted double-linked on arm
Flaky tests (seen before)
- sequential/test-worker-prof
- sequential/test-perf-hooks
- parallel/test-tls-ticket-cluster
- parallel/test-worker-memory
- parallel/test-worker-message-port-message-before-close
sequential/test-timers-blocking-callback
wasi/test-wasi
sequential/test-cpu-prof-dir-worker
parallel/test-inspector-connect-main-thread