Skip to content

http: align destroy w streams

Rodrigo Muino Tomonari requested to merge github/fork/nxtedition/http-client-destroy-no-err into master

This further aligns ClientRequest with streams

Streams that are prematurely destroyed without error through .destroy() do usually not emit an error.

Align ClientRequest with this behavior.

This changes the behavior to not error when:

  • abort() from req.socket has been assigned until req.res has been assigned.
  • destroy() until req.res has been assigned.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports