Skip to content

test: make test-memory-usage predictable

Rodrigo Muino Tomonari requested to merge github/fork/mmarchini/predictable-memory-test into master

The current test relies on undeterministic behavior from V8 GC, and on newer versions of V8 this test ocasionally fails because that behavior changed. Prevent that from happening using --predictable-gc-schedule. If this test fails in the future, it should fail consistently instead of ocasionally, which should help debug.

Ref: https://github.com/nodejs/node-v8/issues/144#issuecomment-597945219 Signed-off-by: Matheus Marchini mmarchini@netflix.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports