Skip to content

buffer: mark pool ArrayBuffer as untransferable

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/buffer-pool-untransferable into master

This removes a footgun in which users could attempt to transfer the pooled ArrayBuffer underlying a regular Buffer, which would lead to all Buffers that share the same pool being rendered unusable as well, and potentially break creation of new pooled Buffers.

This disables this kind of transfer.

Refs: https://github.com/nodejs/node/issues/32752

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports