Skip to content

stream: update comment to indicate unused API

Rodrigo Muino Tomonari requested to merge github/fork/nxtedition/stream-destroy-cb2 into master

destroy w/ callback was previously used by node core. This is no longer the case and the comments should reflect this to avoid confusion.

We briefly discussed making this API public. I'm still good with that but it would require the if (destroyed) branch to use stream.finished. Though if and until then this PR updates the comments to reflect the current state of things. The use of destroy(err, cb) has been refactored away in recent PRs.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports