Skip to content

build: remove .git folders when testing V8

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/makev8 into master

When running make test-v8 V8's gclient sync converts folders under deps/v8/third_party into git repositories. Unfortunately the files that were checked in under deps/v8/third_party/zlib have been modified from the upstream Chromium repository (some files have been deleted and there are whitespace differences in some of the files that were kept) so whenever the Node.js source tree is hard reset/checked out gclient sync notices there are unstaged changes as the files in the Node.js source tree do not match those of the upstream Chromium third party zlib commit.

Refs: https://github.com/nodejs/build/issues/2256

cc @nodejs/v8-update @mmarchini

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports

Loading