Skip to content

[v14.x] deps: V8: ABI compatibility with master

Refs: https://github.com/nodejs/node/pull/32831#issuecomment-613249664

@targos @mmarchini @BethGriggs @nodejs/v8

Contains a number of cherry-picks, and some superficial changes to the API, to ensure ABI compatibility of v14.x with the current V8 master branch.

There are two larger changes here, one that affects how microtasks are run and one that affects how FinalizationGroups are handled. The cherry-picks for those applied cleanly, and I don’t see any reason not to backport them. However, I think that once master picks them up, we will want to clean up our code a bit as a follow-up. If that makes somebody uncomfortable, I would suggest also cherry-picking those changes to master for parity.

Also, make test-v8 and V8 CI still don’t work, but I’ve manually applied these patches here on the V8 tag that our code is based on and successfully ran the tests locally on my V8 clone.

Merge request reports

Loading