Skip to content

stream: some simplification

Rodrigo Muino Tomonari requested to merge github/fork/nxtedition/writable-simplify into master

~7% improvement

NOTE: Contains 2 commits to reduce the number of PRs.

 streams/writable-manywrites.js callback='no' writev='no' sync='no' n=2000000                    6.27 %       ±6.47%  ±8.63% ±11.26%
 streams/writable-manywrites.js callback='no' writev='no' sync='yes' n=2000000            *      8.43 %       ±6.68%  ±8.90% ±11.59%
 streams/writable-manywrites.js callback='no' writev='yes' sync='no' n=2000000                   7.77 %       ±7.88% ±10.49% ±13.69%
 streams/writable-manywrites.js callback='no' writev='yes' sync='yes' n=2000000           *      6.79 %       ±5.75%  ±7.65%  ±9.96%
 streams/writable-manywrites.js callback='yes' writev='no' sync='no' n=2000000          ***     11.31 %       ±6.08%  ±8.11% ±10.60%
 streams/writable-manywrites.js callback='yes' writev='no' sync='yes' n=2000000          **      7.76 %       ±5.46%  ±7.27%  ±9.46%
 streams/writable-manywrites.js callback='yes' writev='yes' sync='no' n=2000000                  6.12 %       ±7.40%  ±9.85% ±12.82%
 streams/writable-manywrites.js callback='yes' writev='yes' sync='yes' n=2000000         **      8.11 %       ±4.90%  ±6.52%  ±8.48%
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports