Skip to content

inspector: throw error when activating an already active inspector

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/inspector-open into master

When the user tries to activate the inspector that is already active on a different port and host, we previously just silently reset the port and host stored in the Environment without actually doing anything for that to be effective. After this patch, we throw an error telling the user to close the active inspector before invoking inspector.open() again.

Fixes: https://github.com/nodejs/node/issues/33012

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports