Skip to content

stream: fix broken pipeline test

Rodrigo Muino Tomonari requested to merge github/fork/nxtedition/pipeline-test into master

An unfortunate overlap between two PR that by themselves pass CI but together fail a test.

https://github.com/nodejs/node/pull/32967 changes so that pipeline does not wait for 'close' on Duplex streams when only interested in one side.

https://github.com/nodejs/node/pull/32968 changed so that all streams are not destroyed.

Which together made one test fail which expected the stream to be destroyed before pipeline callback.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports