Skip to content

lib: make the builtInObjects set deterministic during bootstrap

Rodrigo Muino Tomonari requested to merge github/fork/joyeecheung/deterministic-builtins into main

Make this list explicit instead of filtering over globalThis so that this list is deterministic during the bootstrap regardless of: a) Wether this file is required when the context is going to be serialized, or what the V8 flags are. V8 does not add SharedArrayBuffer, Atomics, WebAssembly, and other flaggable globals e.g. harmony ones to a context that will be serialized. b) Wether this file is required before or after bootstrap (Node.js adds things like Buffer, URL, etc.)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports