Skip to content

[v10.x] n-api: backport ArrayBuffer detaching APIs

Rodrigo Muino Tomonari requested to merge github/fork/legendecas/backport-29768-to-10 into v10.x-staging

This PR backports ArrayBuffer detaching related N-API to v10.x, commits:

n-api: add napi_detach_arraybuffer

As ArrayBuffer#detach is an ecma spec operation (Section 24.1.1.3), it might be good to have it in N-API.

Fixes #29674 (closed)

PR-URL: #29768 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: David Carlier devnexen@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Gabriel Schulhof gabriel.schulhof@intel.com

n-api: implement napi_is_detached_arraybuffer

This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer

Closes: https://github.com/nodejs/node/issues/29955

PR-URL: https://github.com/nodejs/node/pull/30613 Fixes: https://github.com/nodejs/node/issues/29955 Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Gus Caplan me@gus.host Reviewed-By: David Carlier devnexen@gmail.com Reviewed-By: Chengzhong Wu legendecas@gmail.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com

doc,n-api: mark napi_detach_arraybuffer as experimental

As its actual release stage.

PR-URL: https://github.com/nodejs/node/pull/30703 Reviewed-By: Denys Otrishko shishugi@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Michael Dawson michael_dawson@ca.ibm.com Reviewed-By: Tobias Nießen tniessen@tnie.de

Merge request reports