Skip to content

wasi: update start() to better match spec

Rodrigo Muino Tomonari requested to merge github/fork/cjihrig/wasi-start into master

This PR contains two changes:

First commit:

wasi: rename __wasi_unstable_reactor_start()

Upstream WASI has renamed __wasi_unstable_reactor_start() to
_initialize(). This commit updates Node's WASI implementation to
reflect that change.

Second commit:

wasi: update start() behavior to match spec

_start() and _initialize() shouldn't be called from the same
function, as they have different behavior. Furthermore, Node
should throw if both are provided. This commit updates the
implementation, docs, and tests accordingly.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports