Skip to content

win: allow skipping the supported platform check

Rodrigo Muino Tomonari requested to merge github/fork/JaneaSystems/joaocgreis-K4U-skip-plat-check into master

This is an alternative to https://github.com/nodejs/node/pull/33108, which allows skipping the supported platform check by setting an environment variable. This works when Node is executed as a subprocess, such as when running npm/node-gyp, unless the variable is explicitly filtered out.

The MSI is still blocked on Windows 7, the exe or packaged version should be used to run on that system.

I don't think we should land this on LTS branches right away, but no strong opinion. LTS versions might run without issues until their EOL, so I'm inclined to not land this there for now.

cc @nodejs/platform-windows

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports