Skip to content

Revert test-abort-aliased-buffer-overflow

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/revertabortaliasedbufferstest into master

Revert the test and associated Makefile changes from https://github.com/nodejs/node/pull/31740.

This test is dead code as it is not executed as the abort tests' AbortTestConfiguration inherits from SimpleTestConfiguration which does not run tests in subdirectories. https://github.com/nodejs/node/blob/e9518254d79645c3c060ea8d7f4898f8e12af9bb/test/abort/testcfg.py#L6 https://github.com/nodejs/node/blob/e9518254d79645c3c060ea8d7f4898f8e12af9bb/test/testpy/__init__.py#L159

AliasedBuffers do not appear to be intended for direct use by addons so they should not be tested as such anyway. If a test is required for https://github.com/nodejs/node/pull/31740 one should be added as part of the cctest, e.g. as part of test/cctest/test_aliased_buffer.cc.

Refs: https://github.com/nodejs/node/pull/31740

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports