Skip to content

tls: Reset secureConnecting on client socket

Rodrigo Muino Tomonari requested to merge github/fork/davedoesdev/reset-tls-connecting into master

secureConnecting is never set to false on client TLS sockets. So if Http2Session constructor (in lib/internal/http2/core.js) is called after secureConnect is emitted, then it will wrongly wait for a secureConnect event.

This fix sets secureConnecting to false when a client TLS socket has connected.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports