Skip to content

chore: specify unit of time passed to `fs.utimes`

Rodrigo Muino Tomonari requested to merge github/fork/SimenB/patch-1 into master
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Closes #33227 (closed).

Are there any other places where this would be useful to specify? Even though seconds is the base unit, I'm more used to APIs taking ms as default unless otherwise specified. This one might have been extra confusing to me as Date was accepted, and if you do mathematical operations on a Date object, it converts to milliseconds automatically.

Merge request reports