Skip to content

Revert "tls: add highWaterMark option for connect"

Rodrigo Muino Tomonari requested to merge github/fork/puzpuzpuz/revert-tls-hwm-option into master
  1. Reverts commit 58682d82

As it was discussed in #33262 (closed), TLS assumes 16KB as the maximum record size, so it makes no sense to expose hwm option in tls.connect(). Even if we do so, it's also a problem as connections may be reused in https (see https://github.com/nodejs/node/issues/30107#issuecomment-546620095).

  1. Adds a note on applicability of highWaterMark for tls.TLSSocket (though, I'm not sure if that's the right place for this note).
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports