Skip to content

http: fix stalled pipeline bug

Rodrigo Muino Tomonari requested to merge github/fork/indutny/fix/gh-3332 into master

This is a two-part fix:

  • Fix pending data notification in OutgoingMessage to notify server about flushed data too
  • unconsume socket from http parser on pause, to prevent parser from reporting PAUSED error. Previously, no data events were emitted after socket.pause() call. Now with all things happening in C++, socket.pause() has no effect on internal socket while it is consumed. Switching to old mode is enough for now, we should revisit it somewhere later.

Fix: https://github.com/nodejs/node/issues/3332

R=@bnoordhuis @jasnell @trevnorris

cc @nodejs/collaborators

Merge request reports