Skip to content

[v12.x backport] http: don't throw on `Uint8Array`s for `http.ServerResponse#write`

Rodrigo Muino Tomonari requested to merge github/fork/rexagod/backport-33155-to-v12.x into v12.x-staging

Don't throw errors on Uint8Arrays and added test for all valid types.

PR-URL: https://github.com/nodejs/node/pull/33155 Fixes: https://github.com/nodejs/node/issues/33379 Refs: https://github.com/nodejs/node/issues/29829 Reviewed-By: Robert Nagy ronagy@icloud.com Reviewed-By: Anna Henningsen anna@addaleax.net Reviewed-By: Zeyu Yang himself65@outlook.com Reviewed-By: James M Snell jasnell@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports