Skip to content

v8: patch for thenables in PromiseHook API

Rodrigo Muino Tomonari requested to merge github/fork/Qard/thenables-fix-2-the-refixening into master

Thenables produce an additional promise which is not currently emitting before/after hooks from the PromiseHook API in V8. This change makes that additional promise also emit the proper events.

I spent some time digging into V8 trying to figure out a fix for the thenables issue which I previously attempted a higher-level fix for in #33189 and got some resistance. With this change, async_hooks and therefore AsyncLocalStorage will now be able to correctly propagate context into the then(...) method call of a thenable.

I'm submitting this as a PR here to seek help in getting this change into V8 and for us to have the option to land it as a patch, if we want. I haven't written tests for it, though I've tested it manually, as I'm not yet sure how we want to approach landing this.

cc @nodejs/v8 @nodejs/diagnostics @nodejs/async_hooks

Merge request reports