Skip to content

events: deal with Symbol() passed to event constructor

Rodrigo Muino Tomonari requested to merge github/fork/benjamingr/event-constructor-symbol-passed into master

Align behavior of Event constructor when a symbol is passed with what the DOM does.

Old behavior:

  • new Event(Symbol()) creates an event with type "Symbol()" New behavior:
  • new Event(Symbol()) throws an error (like browsers do).

cc @jasnell

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports