Skip to content

test: fix test-eventtarget

Rodrigo Muino Tomonari requested to merge github/fork/lundibundi/unbreak-master-event-target into master

Looks like this slipped through while lending https://github.com/nodejs/node/pull/33611 and https://github.com/nodejs/node/pull/33622 due to the 'old' (3 days) CI.

The NodeEventTarget target test at the end of a file fails with

Error [ERR_EVENT_RECURSION]: The event "foo" is already being dispatched
    at NodeEventTarget.dispatchEvent (internal/event_target.js:250:13)
    at Timeout._onTimeout (/home/lundibundi/dev/node/node/test/parallel/test-eventtarget.js:460:46)
    at listOnTimeout (internal/timers.js:551:17)
    at processTimers (internal/timers.js:494:7) {
  code: 'ERR_EVENT_RECURSION'
}

But since it is being removed anyway (https://github.com/nodejs/node/pull/33665) I decided to just delete it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

/cc @benjamingr @jasnell @nodejs/events

Merge request reports