Skip to content

deps: add defines to nghttp3/ngtcp2 gyp configs

Rodrigo Muino Tomonari requested to merge github/fork/danbev/deps-ngtcp2-nghttp3-compiler-warnings into master

This commit adds two defines to ngtcp2, HAVE_ARPA_INET_H and HAVE_NETINET_IN_H, and one define to nghttp3, HAVE_ARPA_INET_H when the operating system in use is linux.

The motivation for this is that currently, there are compiler warnings generated for these libraries similar to the following:

../deps/ngtcp2/lib/ngtcp2_conv.c: In function ‘ngtcp2_put_uint16be’:
../deps/ngtcp2/lib/ngtcp2_conv.c:129:7: warning:
implicit declaration of function ‘htons’ [-Wimplicit-function-declaration]
  129 |   n = htons(n);
      |       ^~~~~

The inclusion of arpa/inet.h is guarded by the HAVE_ARPA_INET_H macro (see deps/ngtcp2/lib/ngtcp2_conv.h).

These headers are checked by the ngtcp2 and nghttp3 builds using CMake's CheckIncludeFile, and if they are available the above macros are defined.

I'm not sure if we need to have something similar to those checks or if it is alright to add these defines for certain operating systems. Hopefully others will chime in and advice on how to handle this in the best way.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports