Skip to content

Fix an assertion failure at exit in the macOS app sandbox

Rodrigo Muino Tomonari requested to merge github/fork/branchseer/mac_app_sandbox_pr into master

The node process raises at exit an assertion failure at https://github.com/nodejs/node/blob/a85ce885bddaf5fca00dc7d13eb3c5a99663e60f/src/node.cc#L740 when it runs in macOS app sandbox.

This PR includes

  • A basic test that verifies Node.js is able to run in the macOS app sandbox,
  • A fix of the problem described above,
  • A test of the fix.

Checklist

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports