Skip to content

src: refactor configure args to config_flags

Rodrigo Muino Tomonari requested to merge github/fork/rvagg/vcbuild-config-flags into master

Main goal here is to get --download-path to configure so we can solve the ICU problems, but while in there I decided that I was sick of the compounding variables we're using to set up the full string so I refactored.

Removed a bunch of variables and rely on %config_flags% alone where possible, also allow for an external %CONFIG_FLAGS% variable to supply additional arguments to configure to match the behaviour of the Makefile. That way we can CONFIG_FLAGS="--download-path=c:\node-icu".

PTAL @nodejs/platform-windows @nodejs/build

Merge request reports