Skip to content

child_process: Pass `child` in execFile resolve/reject too

Rodrigo Muino Tomonari requested to merge github/fork/awwright/execFile into main

This PR adds a child property to the resolve & reject values to a promisify'd execFile & exec. This simplifies the ability to get at the ChildProcess instance when it's only necessary once the process has exited. (For example, to retrieve the process id).

As discussed in #34234 (closed).

Still needed are tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports