Skip to content

[v14.x] src,doc,test: remove String::New default parameter

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/backport-v14.x-34248 into v14.x-staging

kNormal has been the implicit default for a while now (since V8 7.6).

Refs: https://github.com/v8/v8/commit/e0d7f816990ada28ebe1281ca9431236ef8c6e4f

PR-URL: https://github.com/nodejs/node/pull/34248 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Tobias Nießen tniessen@tnie.de Reviewed-By: James M Snell jasnell@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports