Skip to content

net: allow wider regex in interface name

Rodrigo Muino Tomonari requested to merge github/fork/sxa/ipv6_ifnamefix into master

This is a fix for the issue that is stopping https://github.com/nodejs/node/pull/14500 from being merged due to zone IDs on Linux being network interface names, and the regex for zone ID does not pass the check in net.isIP if it contains non-alphanumeric characters.

We should possibly look at a wider expansion of the characters that can be used as zone IDs but this will trap the more likely ones for now, and allow 14500 to go in - we can create an issue to extend it to a more complete list if desired. dns label added as this may have shown up as part of a lookup call during the new test in the referenced PR.

Cc @bnoordhuis, @indutny, @nodejs/streams @trott @lpinca

Signed-off-by: Stewart Addison sxa@uk.ibm.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports