Skip to content

test: fixup worker + source map test

Rodrigo Muino Tomonari requested to merge github/fork/addaleax/no-test-accessor-mixup into master

The messaging code uses Object.defineProperty(), which accesses value on Object.prototype by default, so some calls to the getter here would actually be expected. Instead, make the list of accessed properties more specific to the tested source map code to avoid flakiness.

Refs: https://twitter.com/addaleax/status/1276289101671608320 Refs: https://github.com/nodejs/node/pull/34057

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports