Skip to content

[v12.x backport] deps: V8: cherry-pick eec10a2fd8fa and #34008

Rodrigo Muino Tomonari requested to merge github/fork/dynatrace-oss-contrib/v12-thenables-v8-again into v12.x-staging

Backport https://github.com/nodejs/node/pull/33778 and https://github.com/nodejs/node/pull/34008 to v12.

There was already a backport PR (https://github.com/nodejs/node/pull/34300) for https://github.com/nodejs/node/pull/33778 but it was removed during creation of 12.18.3 as it looked like it breaks gulp tests on MacOs.

Later it turned out that gulp tests were broken already before therefore I see no reason anymore to not backport this to v12.

In this backport PR I added additionally https://github.com/nodejs/node/pull/34008 which is just a new test to verify the backported fix.

see comments at https://github.com/nodejs/node/pull/33778#issuecomment-662049811

fyi @qard, @MylesBorins

Refs: https://github.com/nodejs/node/pull/33778 Refs: https://github.com/nodejs/node/pull/34008 Refs: https://github.com/nodejs/node/pull/34300 Refs: https://github.com/nodejs/node/pull/34343

Merge request reports