Skip to content

doc: change requirements for objection dismissal

Rodrigo Muino Tomonari requested to merge github/fork/mmarchini/improve-objection-dismiss into master

Previous version would allow dismissal only if the objector is unresponsive to clarifications, but not if they are unresponsive while other collaborators are trying to reach consensus with them. In the spirit of collaboration the objector needs to be open to discuss possible alternatives or should be willing to convince the PR author to drop it. Only if reaching consensus is not possible (either to close the PR or to make changes to it) the issue should be escalated to TSC.

Therefore the guideline is changed to allow dismissal if the objector is unresponsive in the face of "a collaborator proposing a solution or a compromise for the objection". Also adds a note for collaborators to be mindful of holidays and vacations before dismissing an objection.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports