Skip to content

src: fix incorrect SIGSEGV handling in NODE_USE_V8_WASM_TRAP_HANDLER

Rodrigo Muino Tomonari requested to merge github/fork/korniltsev/korniltsev/wasm_sigsegv_fix into master

Pass SA_SIGINFO to sa_flags so TrapWebAssemblyOrContinue is treated as sa_sigaction, not sa_handler, otherwise siginfo_t* info contains some garbage and wasm's SIGSEGV is passed to the node and the whole process crashes.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

reproducer.zip

Merge request reports