Skip to content

inspector: do not hardcode Debugger.CallFrameId in tests

Rodrigo Muino Tomonari requested to merge github/fork/dgozman/test-inspector-callframeid into master

Debugger.CallFrameId is defined as an opaque string [1].

Some tests currently hardcode the value, relying on undocumented internal details of V8. This makes it hard for V8 to change the internal representation.

We should instead use the reported call frame id from the Debugger.paused event directly. This is how every inspector client does it.

[1] https://chromedevtools.github.io/devtools-protocol/tot/Debugger/#type-CallFrameId

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

Merge request reports