Skip to content

docs: `importModuleDynamically` receives a `Script`, not `Module`

Rodrigo Muino Tomonari requested to merge github/fork/SimenB/patch-1 into master
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Matches what I see at runtime and what the tests assert: https://github.com/nodejs/node/blob/900f28aa6d435c937a2e6ddc09fe602476943b00/test/parallel/test-vm-module-dynamic-import.js#L37

As an aside - receiving an object/instance of something that can be inspected would be useful - specifically getting a reference to the vm.Context object the script is executed with. Also its filename. But that's probably something for a feature request?

Merge request reports