Skip to content

build: enable ASLR (PIE) on OS X

Rodrigo Muino Tomonari requested to merge github/fork/woodfairy/osx-pie into master

After conducting several benchmarks, I noticed performance losses of 5-10%. As OS X is not a performance critical platform, as already mentioned by @bnoordhuis, I have removed the -no_pie flag at least for this platform. I'd love to enable PIE for other platforms if the 5-10% speed loss is not too high. I would be happy to hear your opinion on this.

Refs: https://github.com/nodejs/node/issues/33425

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports