Skip to content

deps: cherry-pick 9a49b22 from V8 upstream

Rodrigo Muino Tomonari requested to merge github/fork/danbev/deps-v8-asan-issue into master

Original commit message: Fix alloc/dealloc size mismatch for v8::BackingStore

On newer compilers the {operator delete} with explicit {size_t} argument would be instantiated for {v8::BackingStore} and used in the destructor of {std::unique_ptrv8::BackingStore}. The {size_t} argument is wrong though, since the pointer actually points to a {v8::internal::BackingStore} object. The solution is to explicitly provide a {operator delete}, preventing an implicitly generated {size_t} operator.

Bug:v8:11081

Change-Id: Iee0aa47a67f0e41000bea628942f7e3d70198b83 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2506712 Commit-Queue: Ulan Degenbaev ulan@chromium.org Reviewed-by: Camillo Bruni cbruni@chromium.org Cr-Commit-Position: refs/heads/master@{#70916}

Refs: https://github.com/v8/v8/commit/9a49b2298f65f6b18c5245f3681aca04e5fe4e46 Fixes: https://github.com/nodejs/node/issues/35669

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports