events: remove listener after timer is finished (!35992) · Merge requests · Rodrigo Test / Test Group-nodejs / node · GitLab

Do not update/delete: Banner broadcast message test data

Do not update/delete: Notification broadcast message test data

Rodrigo Muino Tomonari requested to merge github/fork/benjamingr/timer-promises-signal-leak into master Nov 06, 2020

Fixes the memory leak bug described in https://github.com/nodejs/node/issues/35990#issuecomment-722977913

It is very important to me to make the point that I believe we need to do https://github.com/nodejs/node/issues/35990#issue-737609854 if we want users not to run into this footfun.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines