Skip to content

[v14.x backport] [deps] V8: cherry-pick 71736859756b2bd0444bdb0a87a

Rodrigo Muino Tomonari requested to merge github/fork/juanarbol/backport-35222-to-v14.x into v14.x-staging

Refs: https://github.com/nodejs/node/pull/35222

Original commit message:

[heap] Add large_object_threshold to AllocateRaw

This commit adds a check in Heap::AllocateRaw when setting the large_object variable, when the AllocationType is of type kCode, to take into account the size of the CodeSpace's area size.

The motivation for this change is that without this check it is possible that size_in_bytes is less than 128, and hence not considered a large object, but it might be larger than the available space in code_space->AreaSize(), which will cause the object to be created in the CodeLargeObjectSpace. This will later cause a segmentation fault when calling the following chain of functions:

  if (!large_object) {
     MemoryChunk::FromHeapObject(heap_object)
         ->GetCodeObjectRegistry()
         ->RegisterNewlyAllocatedCodeObject(heap_object.address());
  }

We (Red Hat) ran into this issue when running Node.js v12.16.1 in combination with yarn on aarch64 (this was the only architecture that this happed on).

Bug: v8:10808 Change-Id: I0c396b0eb64bc4cc91d9a3be521254f3130eac7b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2390665 Commit-Queue: Ulan Degenbaev ulan@chromium.org Reviewed-by: Ulan Degenbaev ulan@chromium.org Cr-Commit-Position: refs/heads/master@{#69876}

Refs: https://github.com/v8/v8/commit/71736859756b2bd0444bdb0a87a61a0b090cbba2

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports