Skip to content

src: fix node version

Rodrigo Muino Tomonari requested to merge github/fork/richardlau/fixversionh into master

Refs: https://github.com/nodejs/node/commit/348b7a9606da61fbb5437e27f479363114ecf4eb#r44957158 Refs: https://github.com/nodejs/node/pull/36385

Since this is the second time this has happened in a week I'll try to figure out if there's something we can do to try to prevent this happening -- at the very least maybe make the "Revert all changes that were made to src/node_version.h." sentence an explicit step in: https://github.com/nodejs/node/blob/master/doc/guides/releases.md#13-cherry-pick-the-release-commit-to-master But I'll do that in a separate PR so that it doesn't hold up this correction.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Merge request reports