Skip to content

n-api: emit uncaught-exception on calling into modules

Rodrigo Muino Tomonari requested to merge github/fork/legendecas/napi-tsfn into master

Currently, those exceptions were swallowed and the execution may continue in an unstable state.

Following cases are covered in the PR that exceptions can be thrown on calling into modules:

  1. TSFN callbacks
  2. Finalizers

Fixes: https://github.com/nodejs/node/issues/36402

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

Merge request reports